MPS backend to support gates on 3+ qubits #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
reviewed
Mar 20, 2024
schweitzpgi
reviewed
Mar 20, 2024
bmhowe23
reviewed
Mar 20, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
approved these changes
Mar 27, 2024
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(1) Support gates on 3+ qubits for the MPS backend via control gate decomposition.
Experimenting with different strategies to support this feature, implementing it at the simulator implementation level seems to be the best option:
A pure
__qpu__kernel based solution only works for individual gates, but not for thecuda::controlwrapper. The later adds control qubits at runtime (library mode).Need to support C++ kernels, kernel builder, and Python hence different runtimes (NVQIR and library mode execution manager).
Hence, intercepting these multi-controlled gates at the simulator-level prevent the need to spread this logic in multiple places.
(2) Remove all MPS-specific
#ifdefin unit tests (bypass tests that have multi-control gates)(3) Reduce test time for tensornet backends: skip those tests that are not backend-specific; adjust a few tests to make it run faster for tensornet backends (
test_runtime_tensornetandtest_runtime_tensornet-mpsabout 10-15 mins each)Fixes: #884